Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided base ceph-rbd CSI driver example #8664

Merged
merged 7 commits into from
Aug 13, 2020
Merged

Provided base ceph-rbd CSI driver example #8664

merged 7 commits into from
Aug 13, 2020

Conversation

ryanmickler
Copy link
Contributor

No description provided.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 13, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @ryanmickler! Thanks for the contribution!

demo/csi/ceph-csi-plugin/README.md Outdated Show resolved Hide resolved
demo/csi/ceph-csi-plugin/README.md Outdated Show resolved Hide resolved
demo/csi/ceph-csi-plugin/README.md Outdated Show resolved Hide resolved
demo/csi/ceph-csi-plugin/README.md Outdated Show resolved Hide resolved
demo/csi/ceph-csi-plugin/README.md Outdated Show resolved Hide resolved
demo/csi/ceph-csi-plugin/example_volume.hcl Outdated Show resolved Hide resolved
demo/csi/ceph-csi-plugin/ceph-csi-id.tf Show resolved Hide resolved
@tgross tgross merged commit 47ba285 into hashicorp:master Aug 13, 2020
@tgross
Copy link
Member

tgross commented Aug 13, 2020

cc'ing @angrycub as a heads up

@ryanmickler
Copy link
Contributor Author

whoops. i realize the title of the Readme is 'Openstack Ceph-CSI Plugin'. Probably shouldn't have mentioned Openstack there (I borrowed the format from the Openstack Cinder example for consistency)

@frederikbosch
Copy link

@ryanmickler Does this mean that Nomad is able to use Ceph RBD via CSI now? Despite that not all CSI features are implemented?

@ryanmickler
Copy link
Contributor Author

@frederikbosch Yes it does, but I feel more testing is required. The volume creation features arent implemented yet however.

@frederikbosch
Copy link

@ryanmickler Thanks for the quick reply. So you would not take it into production if I understand correctly? Maybe I do not understand CSI well enough, but if there is no volume creation, what does that mean? That I have to create the volume manually before I can use it in a job?

@ryanmickler
Copy link
Contributor Author

@frederikbosch Yeah, I wouldn't say its production ready yet, primarly because of the need to manually generate the correctly formatted CSI ID for each volume post creation. I do the volume creation via ceph cli interface - not ideal

@tomiles
Copy link

tomiles commented Oct 5, 2020

@ryanmickler
Can you detail how you preprovision your volumes in ceph? Do you then register the volume with the specifically formatted CSI ID as a static volume or not? And is the volume/image name in ceph the full CSI ID or just the objectUUID as in your terraform script.

I seem to be overlooking something, because using the latest nomad release and your example I can’t get it to work.

When I don’t register the volume as static in nomad it can’t find the image in ceph.
When I register it as a static volume it can find the correct volume/image in ceph and maps the rbd device on the client node. But it never gets mounted and the job stays stuck in “Pending” status.

@kriestof
Copy link

kriestof commented Nov 2, 2020

I also can not get it work (but with cephfs). If somebody could help please take a look here.

@ryanmickler
Copy link
Contributor Author

sorry for the slow response.
I only ever got one volume to mount correctly with CSI this way, and it for it I had to manually generate the CSI ID. There was too much diff between my production code and what I submitted here so my CSI ID generation script is really lacking and untested (as i mention above)

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants