Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker v19.03.10 #8042

Merged
merged 4 commits into from
Jun 2, 2020
Merged

docker v19.03.10 #8042

merged 4 commits into from
Jun 2, 2020

Conversation

greut
Copy link
Contributor

@greut greut commented May 24, 2020 •
edited
Loading

notnoop
notnoop reviewed Jun 1, 2020
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for this.
Looks like we are still having issues with compiling to windows - https://circleci.com/gh/greut/nomad/1273 . It's an issue that was fixed in docker master moby/moby@c3a0a37 but haven't been included in v19.03.9 (or v19.03.10 , which just got released too) :(.

vendor/vendor.json Outdated Show resolved Hide resolved
vendor/vendor.json Outdated Show resolved Hide resolved
@greut greut changed the title docker v19.03.9 docker v19.03.10 Jun 1, 2020
@greut
Copy link
Contributor Author

greut commented Jun 1, 2020

Looks like we are still having issues with compiling to windows - https://circleci.com/gh/greut/nomad/1273 . It's an issue that was fixed in docker master moby/moby@c3a0a37 but haven't been included in v19.03.9 (or v19.03.10 , which just got released too) :(.

It's still there, govendor permits this kind of cherry-picking. Let's hope things will get nicer before the go mod switch can be done.

@notnoop
Copy link
Contributor

notnoop commented Jun 1, 2020

Sounds good. Thanks for the update. Mind if you rebase against master to remove the irrelevant diff caused by merge commit. I'll merge afterwards.

greut added 4 commits June 1, 2020 22:43
@greut
docker v19.03.9
610075e 
Signed-off-by: Yoan Blanc <[email protected]>
@greut
docker v19.03.10
37974a8 
Signed-off-by: Yoan Blanc <[email protected]>
@greut
docker/cli v19.03.10
67051f0 
Signed-off-by: Yoan Blanc <[email protected]>
@greut
docker pick moby/moby#40021
1b61b16 
Signed-off-by: Yoan Blanc <[email protected]>
@greut greut force-pushed the docker-v19.03.9 branch from 7318c4e to 1b61b16 Compare June 1, 2020 20:44
@greut
Copy link
Contributor Author

greut commented Jun 2, 2020

https://github.com/docker/docker-ce/releases/tag/v19.03.11 yarg :)

@notnoop notnoop merged commit af3d50a into hashicorp:master Jun 2, 2020
@notnoop notnoop mentioned this pull request Jun 2, 2020
Merged
@greut greut deleted the docker-v19.03.9 branch June 6, 2020 11:48
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@notnoop notnoop notnoop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greut @notnoop