Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad: add job status metrics #6003

Merged
merged 1 commit into from
Aug 7, 2019
Merged

nomad: add job status metrics #6003

merged 1 commit into from
Aug 7, 2019

Conversation

pete-woods
Copy link
Contributor

@pete-woods pete-woods commented Jul 24, 2019 •
edited
Loading

Currently the only way to get metrics about the number of running jobs in a nomad cluster is to scrape the jobs API repeatedly.

This means having extra components that need further monitoring and maintenance.

The job summary metrics don't provide the information we need, being related to allocations, rather than current state.

@pete-woods pete-woods force-pushed the add-job-status-metrics branch 2 times, most recently from 2097dc6 to a188f06 Compare July 24, 2019 15:11
@pete-woods pete-woods changed the title Add job status metrics nomad: add job status metrics Jul 24, 2019
@pete-woods
Copy link
Contributor Author

@langmartin This is another PR from us at CircleCI we're hoping to upstream, if you have time to review. 🙂

@langmartin langmartin self-requested a review July 25, 2019 21:46
@pete-woods
Add job status metrics
d07ea34 
This avoids having to write services to repeatedly hit the jobs API
@pete-woods pete-woods force-pushed the add-job-status-metrics branch from a188f06 to d07ea34 Compare July 26, 2019 09:12
@pete-woods pete-woods mentioned this pull request Jul 31, 2019
Merged
@pete-woods
Copy link
Contributor Author

pete-woods commented Aug 5, 2019 •
edited
Loading

Hi folks! Any feedback here would be welcome. I think a number of your customers suffer this (#4036 (comment)) issue, and have seen an issue (#4036) for it and related rotted PR (#4831).

@pete-woods pete-woods mentioned this pull request Aug 5, 2019
Closed
langmartin
langmartin reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@langmartin langmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay reviewing this, it should be ok to merge in 0.10! Just the one question. Thanks for updating the docs!

nomad/leader.go Show resolved Hide resolved
@langmartin langmartin added this to the 0.10.0 milestone Aug 5, 2019
@pete-woods
Copy link
Contributor Author

Thanks! 🎉

@pete-woods
Copy link
Contributor Author

@langmartin @schmichael Do I need to get a second reviewer to move this PR along?

@schmichael schmichael merged commit d45a322 into hashicorp:master Aug 7, 2019
@schmichael
Copy link
Member

Thanks for the reminder @pete-woods! Merged!

schmichael added a commit that referenced this pull request Aug 7, 2019
@schmichael
changelog: add #6003
c5e026a
@pete-woods pete-woods deleted the add-job-status-metrics branch August 7, 2019 18:38
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@langmartin langmartin langmartin approved these changes

Assignees
No one assigned
Labels
theme/metrics
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pete-woods @schmichael @langmartin