Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Faceted Search #5235

Merged
merged 39 commits into from
Mar 12, 2019
Merged

UI: Faceted Search #5235

merged 39 commits into from
Mar 12, 2019

Conversation

DingoEatingFuzz
Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz commented Jan 24, 2019 •
edited
Loading

A three-part saga to bring more searchability to the Jobs and Clients pages.

@DingoEatingFuzz
Freestyle entry for the new multi-select-dropdown component
6f550ca
@DingoEatingFuzz
Simple includes helper that works like Array#includes
dd4bb73
@DingoEatingFuzz
Templating and styling the multi-select-dropdown component
48945a3
@DingoEatingFuzz
Persistence and onSelect handler for the multi-select-dropdown
7de062e
@DingoEatingFuzz
Color alias for tags
36fd51e
@DingoEatingFuzz
Multi-select button-bar support
aadadf2
@DingoEatingFuzz
Round out the freestyle entry
e386004
@DingoEatingFuzz
Tab and keyboard navigation for multi-select
810392a
@DingoEatingFuzz
Test coverage for the multi-select-dropdown component
65a5083
@DingoEatingFuzz
Always left-align the dropdown position to the trigger
451f4ae
@DingoEatingFuzz
Add the right-alignment case to freestyle
6391a61
@DingoEatingFuzz
Harden dropdown styles to avoid accidental cascading
396cfa9
@DingoEatingFuzz
Remove the includes helper in favor of the contains helper
efd7fc0
@DingoEatingFuzz
Merge pull request #5200 from hashicorp/f-ui-multiselect-dropdown
2e52b92 
UI: Multi-select dropdown component
@DingoEatingFuzz
Scaffold the facets and facet options for the jobs list page
8ed8a85
@DingoEatingFuzz
Implement the dynamic facet lists (datacenters and prefixes)
3d87c47
@DingoEatingFuzz
Implement the job list filtering based on facet selection
3b235a1
@DingoEatingFuzz
Support for the no options case
5aef4d9
@DingoEatingFuzz
Introduce encode/decode for array query params
3b8187f
@DingoEatingFuzz
Model facets in the page object
b20dc67
@DingoEatingFuzz
Test coverage for job list facets
0d8dd50
@DingoEatingFuzz DingoEatingFuzz mentioned this pull request Jan 24, 2019
Merged
@DingoEatingFuzz DingoEatingFuzz mentioned this pull request Feb 12, 2019
Merged
@DingoEatingFuzz DingoEatingFuzz mentioned this pull request Feb 14, 2019
Closed
@DingoEatingFuzz
Improve the search box component to make it fluid and iconed
96614af
@DingoEatingFuzz
Add the ember-responsive addon
b8c5b68
@DingoEatingFuzz
Change breakpoints to match Nomad/Bulma widths
f12fe99
@DingoEatingFuzz
Fixes a few minor issues with the multiselect dropdown
84e6a5d 
1. Label no longer bleeds into the downward arrow icon
2. The selection number no longer breaks onto its own line
3. Options have a min-width so short labels can't result in small click
   targets
@DingoEatingFuzz
Make the search box more elastic
b230c45 
1. Set a higher max-width
2. Set a min-width
3. Remove the min-width on mobile, including the invisible size="20" in
   the markup
@DingoEatingFuzz DingoEatingFuzz mentioned this pull request Mar 7, 2019
Merged
@DingoEatingFuzz DingoEatingFuzz changed the base branch from master to 0.9.1-dev March 12, 2019 22:16
@DingoEatingFuzz
Copy link
Contributor Author

Merging into 0.9.1-dev. Each piece was reviewed independently.

@DingoEatingFuzz DingoEatingFuzz merged commit cba97c2 into 0.9.1-dev Mar 12, 2019
@DingoEatingFuzz DingoEatingFuzz deleted the f-ui-faceted-search branch March 12, 2019 22:16
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
theme/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DingoEatingFuzz