client: update driver info on new driver fingerprint #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnoop
commented
Dec 11, 2018
| @@ -1186,6 +1185,7 @@ func (c *Client) updateNodeFromDriver(name string, info *structs.DriverInfo) *st | |||
| } | |||
|
|
|||
| hasChanged = true | |||
|
|
|||
| if newVal == "" { | |||
| delete(c.config.Node.Attributes, attrName) | |||
There was a problem hiding this comment.
This is a bug in this code where node attributes are never removed if the key was removed from driver info. Fixing this requires comparing previous driver info against new one and removing old keys from node attributes. This seems somewhat complex and I suspect some of the attribute changes will be deprecated and removed by 0.10; so not sure if I should fix it here.
Fixes a bug where a driver health and attributes are never updated from their initial status. If a driver started unhealthy, it may never go into a healthy status.
notnoop
force-pushed
the
b-client-update-driver
branch
from
fc417fa to
cae36e4
Compare
schmichael
approved these changes
Dec 11, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where a driver health and attributes are never updated from
their initial status. If a driver started unhealthy, it may never go
into a healthy status.