show preemptions in nomad plan CLI #4823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preetapan
force-pushed
the
f-preemption-plan-cli
branch
from
5ab6674 to
0ff5d01
Compare
schmichael
approved these changes
Nov 5, 2018
| for _, alloc := range resp.Annotations.PreemptedAllocs { | ||
| allocs = append(allocs, fmt.Sprintf("%s|%s|%s", alloc.ID, alloc.JobID, alloc.TaskGroup)) | ||
| } | ||
| c.Ui.Output(formatList(allocs)) |
There was a problem hiding this comment.
[nit] Feel free to return early here and remove else. It would reduce nesting and make the big else clause easier to follow.
command/job_plan_test.go
Outdated
| @@ -7,8 +7,12 @@ import ( | |||
| "strings" | |||
| "testing" | |||
|
|
|||
| "strconv" | |||
command/job_plan_test.go
Outdated
| "github.com/hashicorp/nomad/testutil" | ||
| "github.com/mitchellh/cli" | ||
| require2 "github.com/stretchr/testify/require" |
preetapan
force-pushed
the
f-preemption-plan-cli
branch
from
788e813 to
1d7ebb9
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR augments the output of
nomad planwith info about preemptions.It uses a tiered approach to make sure the CLI doesn't show every single allocid if there are many preemptions. Instead, it groups things and shows summary counts.
There are three cases:
1 - Number of preempted allocations less than 10
2 - Number of unique jobids amongst all preemptions less than 10
3 - Number of unique jobids amongst all preemptions greater than 10
Builds on top of #4794, which should be merged first.