Fixes races accessing node and updating it during fingerprinting #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelseakomlo
approved these changes
Apr 17, 2018
| @@ -1461,6 +1461,7 @@ func (n *Node) Copy() *Node { | |||
| nn.Meta = helper.CopyMapStringString(nn.Meta) | |||
| nn.Events = copyNodeEvents(n.Events) | |||
| nn.DrainStrategy = nn.DrainStrategy.Copy() | |||
| nn.Drivers = copyNodeDrivers(n.Drivers) | |||
There was a problem hiding this comment.
If there is a test for Copy for a node, add this to the test assertion.
| @@ -1752,9 +1755,14 @@ OUTER: | |||
| } | |||
| } | |||
|
|
|||
| // updateNode triggers a client to update its node copy if it isn't doing | |||
| // updateNode updates the Node copy and triggers the client to send the updated | |||
| // Node to the server. This should be done while holding the configLock lock. | |||
| // so already | |||
There was a problem hiding this comment.
I don't think this last comment was meant to be included
| @@ -1752,9 +1755,14 @@ OUTER: | |||
| } | |||
| } | |||
|
|
|||
| // updateNode triggers a client to update its node copy if it isn't doing | |||
| // updateNode updates the Node copy and triggers the client to send the updated | |||
| // Node to the server. This should be done while holding the configLock lock. | |||
There was a problem hiding this comment.
Maybe specify that the caller needs to hold the configLock
There was a problem hiding this comment.
Already states that.
|
Closing in favor of #4166 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4154