Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry all servers on RPC call failure #1735

Merged
merged 14 commits into from
Sep 27, 2016
Merged

Retry all servers on RPC call failure #1735

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
64ac9b9
Retry all servers on RPC call failure
schmichael Sep 22, 2016
6d9670e
Replace periodic handlers with event driven disco
schmichael Sep 24, 2016
6b9be92
Fix agent server set test
schmichael Sep 26, 2016
01ff307
consul -> Consul
schmichael Sep 26, 2016
3bac143
noServers -> noServersErr
schmichael Sep 26, 2016
a35fb33
doDisco -> triggerDiscoveryCh; discovered -> serversDiscoveredCh
schmichael Sep 26, 2016
a4a61e8
Return csv of servers from Stats, not just count
schmichael Sep 26, 2016
93fbc12
Flip disco chan; clarify method names/comments
schmichael Sep 26, 2016
d6b1496
Drop clumsy timeout on discovery notifications
schmichael Sep 26, 2016
ac90d1d
No need to put reaper ticker on the struct
schmichael Sep 26, 2016
ec81fc9
Fix lies found in comments by fact checkers
schmichael Sep 26, 2016
ac29e9c
Remove unused const
schmichael Sep 27, 2016
64aa187
Add #1735 related fixes/improvements to changelog
schmichael Sep 27, 2016
91936f4
Cleanup changelog entries
schmichael Sep 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ IMPROVEMENTS:
* core: Introduce node SecretID which can be used to minimize the available
surface area of RPCs to malicious Nomad Clients [GH-1597]
* cli: `nomad alloc-status` shows allocation creation time [GH-1623]
* client: Retry all servers on RPC call failure [GH-1735]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed RPCs are retried on all servers

* client: Enforce shared allocation directory disk usage [GH-1580]
* client: Introduce a `secrets/` directory to tasks where sensitive data can
be written [GH-1681]
Expand All @@ -17,6 +18,8 @@ BUG FIXES:
* client/fingerprint: Fix inconsistent CPU MHz fingerprinting [GH-1366]
* discovery: Fix old services not getting removed from consul on update
[GH-1668]
* discovery: Fix client flapping when server was in a different datacenter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was -> is

+/- different datacenter as the client

[GH-1641]
* discovery: Fix HTTP timeout with Server HTTP health check when there is no
leader [GH-1656]

Expand Down