Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of block deleting namespaces if the namespace contains a volume into release/1.3.x #13887

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #13880 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


When we delete a namespace, we check to ensure that there are no non-terminal
jobs, which effectively covers evals, allocs, etc. CSI volumes are also
namespaced, so extend this check to cover CSI volumes.

We'll also need to add this check for Secure Variables, but this is in a separate
PR because it'll need to be backported.

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-delete-ns-block-by-csivolume/repeatedly-full-phoenix branch from 708b83e to 59eec75 Compare July 21, 2022 20:14
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 4fae490 into release/1.3.x Jul 21, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-delete-ns-block-by-csivolume/repeatedly-full-phoenix branch July 21, 2022 20:14
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants