Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: tooling for scheduler benchmarking #11725

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Conversation

tgross
Copy link
Member

@tgross tgross commented Dec 21, 2021

Adds a package scheduler/benchmarks with some examples of profile
and benchmarking the scheduler, along with helpers for loading
real-world data for profiling.

This tooling comes out of work done for #11712. These profiles and
test benchmarks have not been added to CI because these particular
profiles are mostly examples and the runs will add an excessive amount
of time to CI runs for code that rarely changes in a way that has any
chance of impacting performance.

@tgross tgross requested review from lgfa29 and schmichael December 21, 2021 20:34
@tgross tgross added the theme/testing Test related issues label Dec 21, 2021
@tgross tgross self-assigned this Dec 21, 2021
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! This is very exciting!

scheduler/benchmarks/benchmarks_test.go Outdated Show resolved Hide resolved
Adds a package `scheduler/benchmarks` with some examples of profiling
and benchmarking the scheduler, along with helpers for loading
real-world data for profiling.

This tooling comes out of work done for #11712. These test benchmarks
have not been added to CI because these particular profiles are mostly
examples and the runs will add an excessive amount of time to CI runs
for code that rarely changes in a way that has any chance of impacting
performance.
@tgross tgross force-pushed the scheduler-benchmark-tooling branch from 26e88f1 to 153b7c0 Compare December 22, 2021 14:30
@vercel vercel bot temporarily deployed to Preview – nomad December 22, 2021 14:30 Inactive
@tgross tgross merged commit e32f024 into main Dec 22, 2021
@tgross tgross deleted the scheduler-benchmark-tooling branch December 22, 2021 15:05
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants