Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: stream raft data to operator raft logs subcommand #11684

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented Dec 15, 2021

Fixes #11451

The nomad operator raft logs command uses a raft helper that reads
in the logs from raft and serializes them to JSON. The previous
implementation returned the slice of all logs and then serializes the
entire object. Update the helper to stream the log entries and then
serialize them as newline-delimited JSON.

@tgross tgross self-assigned this Dec 15, 2021
@tgross tgross changed the title cli: stream raft data to operator raft subcommands cli: stream raft data to operator raft logs subcommand Dec 15, 2021
The `nomad operator raft logs` command uses a raft helper that reads
in the logs from raft and serializes them to JSON. The previous
implementation returned the slice of all logs and then serializes the
entire object. Update the helper to stream the log entries and then
serialize them as newline-delimited JSON.
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.

@tgross tgross merged commit bd18a45 into main Dec 16, 2021
@tgross tgross deleted the operator-raft-log-stream branch December 16, 2021 18:38
@lgfa29 lgfa29 added this to the 1.2.4 milestone Dec 23, 2021
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nomad operator raft _logs doesn't stream logs
4 participants