Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deployment query rate limit #10706

Merged
merged 7 commits into from
Jun 4, 2021
Merged

deployment query rate limit #10706

merged 7 commits into from
Jun 4, 2021

Conversation

jazzyfresh
Copy link
Contributor

@jazzyfresh jazzyfresh commented Jun 4, 2021 •
edited by schmichael
Loading

Make it configurable for users to say how many statestore queries deployments can happen simultaneously. For the use case of huge deployment loads.

@jazzyfresh jazzyfresh requested a review from schmichael June 4, 2021 17:25
schmichael
schmichael reviewed Jun 4, 2021
View reviewed changes
command/agent/agent.go Outdated Show resolved Hide resolved
schmichael
schmichael reviewed Jun 4, 2021
View reviewed changes
command/agent/command.go Outdated Show resolved Hide resolved
jazzyfresh
jazzyfresh commented Jun 4, 2021
View reviewed changes
command/agent/config.go Outdated Show resolved Hide resolved
schmichael
schmichael reviewed Jun 4, 2021
View reviewed changes
command/agent/config.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – nomad June 4, 2021 17:35 Inactive
@schmichael
Update command/agent/config.go
e40c70b 
Co-authored-by: Michael Schurter <[email protected]>
@vercel vercel bot temporarily deployed to Preview – nomad June 4, 2021 17:37 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad June 4, 2021 17:48 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad June 4, 2021 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad June 4, 2021 19:08 Inactive
@jazzyfresh jazzyfresh changed the title deployment rate limit deployment query rate limit Jun 4, 2021
@vercel vercel bot temporarily deployed to Preview – nomad June 4, 2021 19:18 Inactive
@schmichael
Copy link
Member

For the record: we decided out of band to skip documentation for this parameter for now as it is currently only to ease broader testing in production scenarios.

@jazzyfresh jazzyfresh merged commit bdf2555 into main Jun 4, 2021
@jazzyfresh jazzyfresh deleted the deployment-rate-limit branch June 4, 2021 19:38
schmichael pushed a commit that referenced this pull request Jun 4, 2021
@schmichael
deployment query rate limit (#10706)
c74ab42
@schmichael schmichael mentioned this pull request Jun 4, 2021
Merged
schmichael added a commit that referenced this pull request Jun 4, 2021
@schmichael
Merge pull request #10707 from hashicorp/v1.0.2-deploy-query-param
3803490 
deployment query rate limit (#10706)
This was referenced Jun 14, 2021
Merged
Open
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmichael schmichael schmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jazzyfresh @schmichael