UI: set memory max for oversubscription. #10309
Conversation
| console.log(find('.annotation').innerText); | ||
| assert.ok(find('.annotation').innerText.includes('/ 256 MiB reserved, 512 MiB max')); |
There was a problem hiding this comment.
I've struggled with getting this test to pass - I always get 0 MiB / 0 MiB reserved. I get the same text in the above test as well. Would love pointers for how to set it up.
There was a problem hiding this comment.
Since the template uses @allocation={{this.resource}} I think your property-setting call would need to be this.setProperties({ resource: alloc, metric: 'memory'}). But also I think alloc should be extracted from the job created with the resourceSpec vs created anew. I could pair with you on this if you like?
There was a problem hiding this comment.
Apparently, the issue was a bit gnarlier than that - the tracker spy/mock didn't actually fill-in the annotation info, and there is something odd about the mirage creation if multiple jobs/annotations are in play. Anyways, I took out the test, and would love to have a frontend engineer take over if possible :( sorry!
Ember Asset Size actionAs of 1eee305 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
notnoop
changed the title
notnoop
force-pushed
the
f-ui-memory-max
branch
from
8d9b3eb to
241156a
Compare
notnoop
force-pushed
the
f-ui-memory-max
branch
from
241156a to
1eee305
Compare
|
Closing, superseded by #10459 . |
|
#10459 isn’t quite the same as this, I just wanted to start with the bare minimum given the time constraints 😳 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Display reserved vs max memory for allocations/tasks with memory oversubscription, introduced in #10247 .
Implements the alloc/task display memory info part of #10268 .
Needless to say, I very much lack javascript experience, and I'm unfamiliar with frontend patterns, so feel free to ignore the PR and do it the "proper" way and I can learn by watching it. Thanks!
For a task with
memory_maxset, here are the screen shots:After: