-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consul Connect service port definition confusion #9996
Comments
The working example you have here matches the docs for the |
Is that expected behavior? |
Yes. Another way to look at it is that the default |
For me it's confusing. Could be a doc issue? For example yes, if we look at sidecar stanza doc we see a clear example with the port as an int. But that page doesn't tell us anything about that port has to be an int, not a label. If we go to the service stanza doc we see the service example with the port as a label. So my question is - how should the end-user understand that I have to use int and not a label for Consul Connect cases? |
Yeah the docs definitely could use some improvement here, especially because in the case of Consul Connect we're always in
Going to mark this as a docs issue to fix. |
Could it be also a validation issue? Like it would be great if plan\run would highlight it as an issue. |
I see that @krishicks has a PR open in #9987 which should fix the docs, and there's a discussion there about how this could be better handled. (Assigning to @krishicks only so that we don't have something marked "in progress" that has no owner... this will close out once that PR is merged. We can keep #9907 open which has a bit more detail.) |
@tgross I'm using now named ports for sidecars to spin up sidecar on a certain interface. It works since Nomad v1.0.4 and was introduced by #9975
|
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Hi,
So I just noticed that if I define a port in network stanza and when re-use it in service as a label - it doesn't work with Consul Connect integration.
By "doesn't work" I mean that when I set that service as an upstream to other Nomad task it creates an Envoy endpoint but no traffic could pass through it. It instantly closes the connection.
Example of non-working configuration:
Example of working configuration:
Is it something expected that I missed in docs?
Nomad version: 1.0.2
Consul version: 1.9.2
The text was updated successfully, but these errors were encountered: