Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Default Consul Sidecar Healthcheck #9975

Merged
merged 17 commits into from
Feb 16, 2021
Merged

Updated Default Consul Sidecar Healthcheck #9975

merged 17 commits into from
Feb 16, 2021

Conversation

AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Feb 4, 2021 •
edited
Loading

@vercel vercel bot temporarily deployed to Preview – nomad February 4, 2021 20:21 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 8, 2021 10:51 Inactive
@AndrewChubatiuk AndrewChubatiuk changed the title enabled hairpin mode Updated Default Consul Sidecar Healthcheck Feb 8, 2021
@vercel vercel bot temporarily deployed to Preview – nomad February 8, 2021 10:59 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 8, 2021 11:12 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 8, 2021 16:17 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 8, 2021 19:54 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 8, 2021 20:13 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 9, 2021 12:05 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 9, 2021 12:46 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 9, 2021 13:32 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 9, 2021 13:54 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 9, 2021 13:58 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 9, 2021 14:27 Inactive
@AndrewChubatiuk
Copy link
Contributor Author

@nickethier @shoenig
Could you guys please review this PR?

@vercel vercel bot temporarily deployed to Preview – nomad February 9, 2021 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 13, 2021 00:32 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 13, 2021 00:34 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad February 13, 2021 00:43 Inactive
shoenig
shoenig approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AndrewChubatiuk !

@shoenig shoenig merged commit 49e5699 into hashicorp:master Feb 16, 2021
@AndrewChubatiuk AndrewChubatiuk deleted the connect-host-networks-fix branch February 16, 2021 16:10
@tgross tgross added this to the 1.0.4 milestone Feb 16, 2021
@tgross tgross mentioned this pull request Feb 16, 2021
Closed
@AndrewChubatiuk AndrewChubatiuk mentioned this pull request Mar 25, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

Assignees

@shoenig shoenig

Labels
None yet
Projects
None yet
Milestone
1.0.4
Development

Successfully merging this pull request may close these issues.

consul/connect: sidecar healthchecks are failing when host_networks are defined
4 participants
@AndrewChubatiuk @grynko @shoenig @tgross