Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volumes: implement plan diff for volume requests #9973

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

tgross
Copy link
Member

@tgross tgross commented Feb 4, 2021

Fixes #9962

The details of host volume and CSI volume requests do not show up in nomad plan outputs, although the updates are detected by the scheduler and result
in an update as expected.

@tgross tgross requested review from shoenig and drewbailey February 4, 2021 19:50
@tgross tgross added this to the 1.0.4 milestone Feb 4, 2021
Copy link
Contributor

@drewbailey drewbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

nomad/structs/diff.go Outdated Show resolved Hide resolved
The details of host volume and CSI volume requests do not show up in `nomad
plan` outputs, although the updates are detected by the scheduler and result
in an update as expected.
@tgross
Copy link
Member Author

tgross commented Feb 4, 2021

Added a changelog entry (and fixed the ordering). Will merge once we're green

@tgross tgross merged commit fee2802 into master Feb 4, 2021
@tgross tgross deleted the b-volume-diff branch February 4, 2021 21:55
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume diffs do not appear in 'nomad job plan'
3 participants