Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: add tests and fix for detected host_network and to port field changes #9937

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

nickethier
Copy link
Member

This PR changes the scheduler to detect if a to or host_network field is updated.

fixes #9728

@nickethier nickethier requested a review from shoenig February 1, 2021 21:00
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since this is now using a structs object, do you think it would be worthwhile to implement .Equals on it rather than continuing to lean on reflect.DeepEquals?

@tgross tgross added this to the 1.0.4 milestone Feb 2, 2021
@nickethier
Copy link
Member Author

LGTM. Since this is now using a structs object, do you think it would be worthwhile to implement .Equals on it rather than continuing to lean on reflect.DeepEquals?

I thought about this but then we'd probably need to take ordering into account where here we're really just reusing the struct as a convenient tuple and we know we don't have to worry about ordering. I can't think of a place where we would be comparing port mappings.

@nickethier nickethier merged commit a957a5c into master Feb 2, 2021
@nickethier nickethier deleted the b-9728 branch February 2, 2021 18:54
tgross added a commit that referenced this pull request Feb 23, 2021
tgross added a commit that referenced this pull request Feb 23, 2021
tgross added a commit that referenced this pull request Feb 23, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating job with host_network, no effect
3 participants