Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dominant-baseline instead of alignment-baseline to get firefox support #9894

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

DingoEatingFuzz
Copy link
Contributor

Before:
Labels are top-aligned to their parent elements

After:
Labels are center aligned to their parent elements

@github-actions
Copy link

Ember Asset Size action

As of c76b5e1

Files that got Smaller 🎉:

File raw gzip
nomad-ui.css -15 B +49 B

Files that stayed the same size 🤷‍:

File raw gzip
nomad-ui.js 0 B 0 B
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@DingoEatingFuzz DingoEatingFuzz merged commit f89cfc3 into master Jan 26, 2021
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui/topo-viz-align-text-ff branch January 26, 2021 17:31
@github-actions
Copy link

Ember Test Audit comparison

master c76b5e1 change
passes 1544 1544 0
failures 0 0 0
flaky 0 0 0
duration 7m 01s 396ms 7m 55s 562ms +54s 166ms

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants