don't prefix json logging (fixes #9489) #9795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
requested changes
Jan 20, 2021
There was a problem hiding this comment.
Hi @roccoblues! Thanks for contributing this PR! I've pulled this branch locally and tested it out and it LGTM.
Co-authored-by: Tim Gross <[email protected]>
tgross
approved these changes
Jan 20, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the extra spaces at the beginning of json logging (#9489).
However I'm not a 100% happy with the current solution. Ideally we would switch the UI to
logging.HcLogUIafter reading the config. But to initialize one we need a logger, which needs a UI. Classic Catch-22.