Events/acl events #9595
Merged
Events/acl events #9595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbailey
force-pushed
the
events/acl-events
branch
from
2c34da4 to
3a4804a
Compare
tgross
approved these changes
Dec 9, 2020
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
drewbailey
force-pushed
the
events/acl-events
branch
from
a51f552 to
99a196f
Compare
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
krishicks
reviewed
Dec 10, 2020
test that values are omitted test event creation test acl events payloads are pointers fix failing tests, do all security steps inside constructor
drewbailey
force-pushed
the
events/acl-events
branch
from
c86081a to
be313da
Compare
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
krishicks
approved these changes
Dec 11, 2020
tgross
approved these changes
Dec 11, 2020
| setupfn func(t *testing.T, fsm *nomadFSM) | ||
| raftReq func(t *testing.T) []byte | ||
| reqTopic structs.Topic | ||
| eventfn func(t *testing.T, e []structs.Event) |
There was a problem hiding this comment.
I really like how this test got structured with these testing funcs as test cases. 👍
There was a problem hiding this comment.
Thanks, I think this one is right in the sweet spot for it being legible. table tests with huge tables and small test case runs can get hard to read 🤷♂️
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
schmichael
pushed a commit
that referenced
this pull request
Dec 16, 2020
* fix acl event creation * allow way to access secretID without exposing it to stream test that values are omitted test event creation test acl events payloads are pointers fix failing tests, do all security steps inside constructor * increase time * ignore empty tokens * uncomment line * changelog
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the transaction type for acl token and policy upsert requests to include the message type, which includes it in the event stream.
An unexported
secretIDvalue is added to ACLTokenEvent so that the event broker can access the secretID value when evaluating if a subscription should be closed or not, while ensuring that the secretID value is not included in the event stream output when marshaled.