applyUpsertJob causes duplicate job events in event stream

[drewbailey]

When testing the event stream, we noticed when registering a job, multiple JobRegister events are added to the event stream.

This seems related to #8435. The logic in the state store to set the job status specifically empties out the current value if the index used to update the status is equal to the jobs create status.

nomad/nomad/state/state_store.go

Lines 4429 to 4432 in e64d528

	oldStatus := job.Status
	if index == job.CreateIndex {
	oldStatus = ""
	}

This causes a second insertion into the jobs table with an identical value to what was inserted previously in the job register step.

branch with test: https://github.com/hashicorp/nomad/compare/drew/job-status

[tgross]

@drewbailey should this be closed by #9768?

[drewbailey]

Yep, thanks!

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.