Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repurpose dispatch-job capability to dispatch periodic jobs #9205

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Oct 28, 2020

This PR repurpose dispatch-job for periodic job force invocation in addition to parameterized jobs.

Currently, force evaluating a periodic job requires submit-job capability, a too powerful capability as it allows submitting arbitrary jobs to the cluster. In contrast, submitting a new parameterized job require submit-job capability, but manually invoking it only requires dispatch-job. Having a lower-scoped capability allow delegating debugging or recovery handling to operators or tools with less privileges.

I've considered introducing a new capability just for periodic jobs, but I thought such fine-grain capability seems unwarranted. In both the periodic and parameterized job, we'd want operators to invoke jobs that are already registered and allowed in the cluster.

Closes #7703

@notnoop notnoop requested a review from schmichael October 28, 2020 15:51
@notnoop notnoop self-assigned this Oct 28, 2020
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget to update docs:

@notnoop
Copy link
Contributor Author

notnoop commented Nov 2, 2020

Thanks! Updated changelog and docs!

@notnoop notnoop merged commit bdd4134 into master Nov 2, 2020
@notnoop notnoop deleted the b-gh-7703 branch November 2, 2020 18:12
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace ACL policy to allow force launching existing periodic jobs but deny modification
2 participants