Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Always show the file browser for allocations and tasks. #9172

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

DingoEatingFuzz
Copy link
Contributor

Before, we'd show a helpful error message when a task isn't running instead of erroring in a generic way. Turns out when an alloc is terminal but reachable, the filesystem is left behind and we were hiding it.

Now it is always shown and in the event that something errors, it'll either be generic, or--more commonly--a 404 of the allocation.

Fixes #9065

Before, we'd show a helpful error message when a task isn't running
instead of erroring in a generic way. Turns out when an alloc is
terminal but reachable, the filesystem is left behind so we were hiding
it.

Now it is always shown and in the event that something errors, it'll
either be generic, or--more commonly--a 404 of the allocation.
@github-actions
Copy link

github-actions bot commented Oct 26, 2020

Ember Asset Size action

As of 05f3bf2

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -673 B -111 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Oct 26, 2020

Ember Test Audit comparison

master 05f3bf2 change
passes 1450 1448 -2
failures 0 0 0
flaky 0 0 0
duration 7m 45s 133ms 6m 56s 781ms -48s 352ms

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice improvement 🤩 I tried this locally and it worked as expected, though I wasn’t able to force an allocation 404, but I guess it would mean you can’t access the allocation route at all?

@DingoEatingFuzz
Copy link
Contributor Author

Yeah, it wouldn't be navigable from elsewhere in the UI. The way I tested it was...

  1. Run a job
  2. Stop the allocation
  3. Go to the file browser of the completed allocation
  4. Run http PUT localhost:4646/v1/system/gc to remove the completed allocation
  5. Refresh the file browser tab, receive 404.

@DingoEatingFuzz DingoEatingFuzz merged commit 607aac4 into master Oct 26, 2020
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui/logs-for-fails branch October 26, 2020 17:36
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable files tab for terminal allocations and tasks
2 participants