csi: allow volume detach to take a node ID prefix #9041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hashicorp/nomad/bxzceg2n7 |
tgross
force-pushed
the
b-csi-volume-detach-node-prefix
branch
from
ee69d76 to
330d36a
Compare
tgross
force-pushed
the
b-csi-volume-detach-node-prefix
branch
from
330d36a to
b42b838
Compare
shoenig
approved these changes
Oct 7, 2020
Fixes a bug where the `nomad volume detach` command would not accept a node ID prefix instead of a full node ID. The volume ID is already prefix matched server-side.
tgross
force-pushed
the
b-csi-volume-detach-node-prefix
branch
from
b42b838 to
989a9fe
Compare
|
Fixed the merge conflict with the changelog. Will merge this once CI gives me the ✅ again. |
This was referenced Oct 7, 2020
fredrikhgrelland
pushed a commit
to fredrikhgrelland/nomad
that referenced
this pull request
Oct 22, 2020
Fixes a bug where the `nomad volume detach` command would not accept a node ID prefix instead of a full node ID. The volume ID is already prefix matched server-side.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8963
Fixes a bug where the
nomad volume detachcommand would not accept a node IDprefix instead of a full node ID. The volume ID is already prefix matched
server-side.