Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller 0.12 mbit deprecation PR #8911

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Sep 17, 2020

This is a small subset of #8743 that's more conservative to be included in 0.12.5.

It primarily includes the job sample and doc updates. I can be persuaded to include the warnings as well as these are relatively small.

@notnoop notnoop added this to the 0.12.5 milestone Sep 17, 2020
@notnoop notnoop requested a review from tgross September 17, 2020 13:06
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I also ran both the example asset jobs and they work as expected.

@notnoop notnoop merged commit 1b8ce46 into master Sep 17, 2020
@notnoop notnoop deleted the f-task_network_warning-smaller branch September 17, 2020 13:11
notnoop pushed a commit that referenced this pull request Sep 17, 2020
teutat3s pushed a commit to teutat3s/nomad that referenced this pull request Oct 27, 2020
…ng-smaller

Smaller 0.12 mbit deprecation PR
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants