Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Add handling for allocation-less exec URL #8856

Merged
merged 1 commit into from
Sep 15, 2020
Merged

UI: Add handling for allocation-less exec URL #8856

merged 1 commit into from
Sep 15, 2020

Conversation

backspace
Copy link
Contributor

This closes #8769. This new-window-opening code is not possible
to properly exercise within Ember’s testing facilities 😞

@backspace
Add handling for allocation-less exec URL
1f593bc 
This closes #8769. This new-window-opening code is not possible
to properly exercise within Ember’s testing facilities 😞
@backspace backspace self-assigned this Sep 9, 2020
@github-actions
Copy link

github-actions bot commented Sep 9, 2020

Ember Asset Size action

As of 1f593bc

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +27 B +22 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Sep 9, 2020

Ember Test Audit comparison

master 1f593bc change
passes 1386 1387 +1
failures 0 0 0
flaky 0 0 0
duration 7m 27s 538ms 6m 49s 018ms -38s 520ms

@backspace backspace added this to the 0.12.5 milestone Sep 14, 2020
@notnoop notnoop removed this from the 0.12.5 milestone Sep 15, 2020
@backspace backspace merged commit 9b5c428 into master Sep 15, 2020
@backspace backspace deleted the b-ui/generate-exec-url-no-allocation branch September 15, 2020 19:48
notnoop pushed a commit that referenced this pull request Sep 16, 2020
@backspace
Add handling for allocation-less exec URL (#8856)
bdea884 
This closes #8769. This new-window-opening code is not possible
to properly exercise within Ember’s testing facilities 😞
@notnoop notnoop added this to the 0.12.5 milestone Sep 16, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DingoEatingFuzz DingoEatingFuzz DingoEatingFuzz approved these changes

Assignees

@backspace backspace

Labels
theme/ui type/bug
Projects
None yet
Milestone
0.12.5
Development

Successfully merging this pull request may close these issues.

Cannot switch tasks in the exec window once an exec session has begun
3 participants
@backspace @DingoEatingFuzz @notnoop