core: Pause/Resume Nack timeout while eval is in plan queue #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // handle the case that the receiving worker dies. | ||
| id := plan.EvalID | ||
| token := plan.EvalToken | ||
| if err := p.srv.evalBroker.PauseNackTimeout(id, token); err != nil { |
There was a problem hiding this comment.
Can we move this before the Enqueue? That way we can avoid Enqueue if its not outstanding or there is a token mismatch
|
LGTM |
dadgar
force-pushed
the
f-nack-timeout-pausing
branch
from
5580897 to
72901a9
Compare
dadgar
added a commit
that referenced
this pull request
Mar 4, 2016
core: Pause/Resume Nack timeout while eval is in plan queue
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core: Pause NackTimeout while in the plan_queue as progress is being made.
This avoids evals from being Nacked by the EvalBroker timeout even though progress is being made.