Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashes in var names #857

Merged
merged 1 commit into from
Feb 29, 2016
Merged

Allow dashes in var names #857

merged 1 commit into from
Feb 29, 2016

Conversation

monder
Copy link
Contributor

@monder monder commented Feb 27, 2016

I don't really know in which direction to fix it:

  • AWS fingerprinting (env_aws.go#L111) sets the variables with dashes.
  • Replacement regexp does not allow dashes in names.

Now there is no way to pass variables like platform.aws.placement.availability-zone, unique.platform.aws.local-ipv4 to the process.
Maybe lets allow it?

@dadgar
Copy link
Contributor

dadgar commented Feb 29, 2016

Looks great thanks for the fix.

dadgar added a commit that referenced this pull request Feb 29, 2016
Allow dashes in var names
@dadgar dadgar merged commit dde1e0a into hashicorp:master Feb 29, 2016
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants