Handle Scaling Policies in Job Plan endpoint #8567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8544
This PR fixes a bug where using
nomad job plan ...
always report no change if the submitted job contain scaling.The issue has three contributing factors:
This PR fixes the first two factors. Changing the scheduler to be more strict might make sense, but may violate some idempotency invariant or make the scheduler more brittle.
I added the test early, so reviewer can see the failing
TestJobEndpoint_Plan_Scaling
test in https://app.circleci.com/pipelines/github/hashicorp/nomad/10845/workflows/f535e389-633b-46db-b304-353c79c3894e/jobs/87394 but is green afterwards.