better error handling around Scaling->Max #8360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…messages * made api.Scaling.Max a pointer, so we can detect (and complain) when it is neglected * added checks to HCL parsing that it is present * when Scaling.Max is absent/invalid, don't return extraneous error messages during validation * tweak to multiregion handling to ensure that the count is valid on the interpolated regional jobs resolves #8355
shoenig
approved these changes
Jul 6, 2020
| @@ -1345,7 +1345,7 @@ func TestParse(t *testing.T) { | |||
| Name: helper.StringToPtr("group"), | |||
| Scaling: &api.ScalingPolicy{ | |||
| Min: nil, | |||
| Max: 0, | |||
| Max: helper.Int64ToPtr(10), | |||
There was a problem hiding this comment.
Intentionally changed from 0 to 10?
| - `count` `(int)` - Specifies the number of instances that should be running | ||
| under for this group. This value must be non-negative. This defaults to the | ||
| `min` value specified in the [`scaling`](/docs/job-specification/scaling) | ||
| block, if present; otherwise, this defaults to `1`. |
There was a problem hiding this comment.
uh, actually, i'll leave it alone. i was just trying to update the default here, not the mechanics of count
LGTM |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we don't do validation on the
apiobjects, just on the structs objects on the other side of the RPC call. therefore, as a hack that i'm not entirely happy with, whenapi.ScalingPolicy.Maxis missing, i set an invalid value forstructs.ScalingPolicy.Max(I don't want this to be a pointer), and then respond during validation with a catch-all error message.also updated website to document
Group->Countdefault value@tgross , does https://github.com/hashicorp/nomad/pull/8360/files#diff-396d9428285e4245041a3d0b15546d5dR5963 look okay? i did a local multiregion test and everything behaved.
resolves #8355