Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing documentation examples regarding helpers #8196

Closed
neidiom opened this issue Jun 18, 2020 · 4 comments
Closed

Confusing documentation examples regarding helpers #8196

neidiom opened this issue Jun 18, 2020 · 4 comments
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/docs Documentation issues and enhancements theme/driver/docker

Comments

@neidiom
Copy link

neidiom commented Jun 18, 2020

https://www.nomadproject.io/docs/drivers/docker/

First example is

plugin "docker" {
  config {
    endpoint = "unix:///var/run/docker.sock"

    auth {
      config = "/etc/docker-auth.json"
      helper = "docker-credential-aws"
    }
}

where docker-credential-aws is used

then we go to

The script's name must begin with docker-credential- and this option should include only the basename of the script, not the path.

where it states that it has to start with docker-credential- keywords

then we go to

client {
  enabled = true
}

plugin "docker" {
  config {
    auth {
      # Nomad will prepend "docker-credential-" to the helper value and call
      # that script name.
      helper = "ecr"
    }
  }
}

where it says that Nomad will prepend "docker-credential-" to the helper value.

Am I missing something?

@shoenig
Copy link
Member

shoenig commented Jun 18, 2020

Thanks for reporting, @neidiom !

I believe the first example is a documentation bug. Looks like the driver always prepends the docker-credential- prefix.

Would you like to open a quick PR to fix that first example?

@shoenig shoenig added theme/docs Documentation issues and enhancements theme/driver/docker labels Jun 18, 2020
@tgross
Copy link
Member

tgross commented Jun 18, 2020

Possibly related: #7357

@tgross tgross added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Aug 25, 2020
@tgross
Copy link
Member

tgross commented Nov 19, 2020

Fixed in #8913 and #7801

@tgross tgross closed this as completed Nov 19, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/docs Documentation issues and enhancements theme/driver/docker
Projects
None yet
Development

No branches or pull requests

3 participants