Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: claim releases don't need to go thru GC eval #7933

Closed
tgross opened this issue May 12, 2020 · 1 comment · Fixed by #8021
Closed

CSI: claim releases don't need to go thru GC eval #7933

tgross opened this issue May 12, 2020 · 1 comment · Fixed by #8021

Comments

@tgross
Copy link
Member

tgross commented May 12, 2020

Following the new volumewatcher in #7794 and performance improvements to it that landed afterwards, there's no particular reason we should be threading claim releases through the GC eval rather than writing an empty CSIVolumeClaimRequest with the mode set to CSIVolumeClaimRelease, just as the GC evaluation would do.

This will reduce the amount of raft writes by 1 and reduce cross-server RPCs by 1 for each volume we release claims on.

These are the two places to replace new evals with de-duplicated CSIVolumeClaimBatchRequests:

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant