Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Linux ARM64 test target #7769

Open
tgross opened this issue Apr 21, 2020 · 6 comments
Open

e2e: Linux ARM64 test target #7769

tgross opened this issue Apr 21, 2020 · 6 comments

Comments

@tgross
Copy link
Member

tgross commented Apr 21, 2020

We support ARM and a few users actually use it. AWS has ARM instance types now, so adding a test target for that would be a matter of:

  • creating a new AMI build for it
  • making sure we have ARM builds available as artifacts (on S3 and/or CircleCI)
  • making sure the framework properly handles the platform name
@tgross tgross added the theme/testing Test related issues label Apr 21, 2020
@tgross tgross added this to the unscheduled milestone Apr 21, 2020
@tgross
Copy link
Member Author

tgross commented May 21, 2020

This would help with identifying problems like #7989

@tgross tgross removed this from the unscheduled milestone Feb 12, 2021
@odidev
Copy link

odidev commented Aug 4, 2021

Hi Team,

I have built nomad from source for arm64 on AWS ubuntu environment and tested the created binary with make test-nomad command, getting 5914 tests, 50 skipped, 100 failures. Please check the detailed logs of failures below:

Nomad-arm64-ubuntu-aws-test-logs.txt

Although, getting the same result (2172 tests, 6 skipped) as circle-ci logs when running the tests in nomad directory by updating the GOTEST_PKGS value in GNUMakefile to ./nomad/...

Do you have any plans for supporting arm64 platform?

It would be helpful if you could share some pointers to resolve the above failures.

@odidev
Copy link

odidev commented Dec 9, 2021

Hi Team,

I have modified the config.yml file to add support for arm64 platform and trigger tests for arm64 platform, please find below the changes:

Commit link: odidev@11e35c6

Although, only the nomad folder test cases are getting successfully passed without any failures in rest of the folders we are getting some failures in case of arm64 platform.

If you are interested, I will be willing to raise a PR for arm64 support in circle-ci.

@tgross
Copy link
Member Author

tgross commented Dec 9, 2021

Hi @odidev! Running the unit tests on ARM on CircleCI would potentially be interesting, but I'm going to gently discourage you from doing that work because our release engineering folks are talking about porting us off of CircleCI and much of that work would get thrown away.

For E2E the CircleCI runner isn't running the actual cluster; the cluster is deployed and running on AWS and the CircleCI runner is just running the CLI (which is uninteresting from an ARM testing perspective). So for us to do E2E testing vs ARM, we'd need to have a whole separate ARM target environment, which is what this GitHub issue is.

@odidev
Copy link

odidev commented Dec 22, 2021

Hi @tgross thanks for the quick response. If you are interested, I can help with respect to enabling Arm testing through github actions. Since you are running the test on AWS, it is possible to use graviton instances to test on arm.

@tgross
Copy link
Member Author

tgross commented Dec 22, 2021

If you are interested, I can help with respect to enabling Arm testing through github actions.

Thanks, but we're not going to run tests on GitHub Actions; the organization has standardized on CircleCI at least for the time being.

Since you are running the test on AWS, it is possible to use graviton instances to test on arm.

Yup, I'm aware of that. It's a matter of building and testing the AMI to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants