fingerprint: handle incomplete AWS imitation APIs #7509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2020 11:13
Test that nomad doesn't set empty/bad network configuration when in an environment that does incomplete immitation of EC2 Metadata API.
Fix a regression where we accidentally started treating non-AWS environments as AWS environments, resulting in bad networking settings. Two factors some at play: First, in [1], we accidentally switched the ultimate AWS test from checking `ami-id` to `instance-id`. This means that nomad started treating more environments as AWS; e.g. Hetzner implements `instance-id` but not `ami-id`. Second, some of these environments return empty values instead of errors! Hetzner returns empty 200 response for `local-ipv4`, resulting into bad networking configuration. This change fix the situation by restoring the check to `ami-id` and ensuring that we only set network configuration when the ip address is not-empty. Also, be more defensive around response whitespace input. [1] #6779
notnoop
commented
Mar 26, 2020
cgbaker
approved these changes
Mar 26, 2020
notnoop
commented
Mar 26, 2020
| } | ||
| } | ||
| newNetwork = &structs.NetworkResource{ | ||
| Device: "eth0", |
There was a problem hiding this comment.
Just realized we probably shouldn't assume network being eth0 :( - will fix that in a follow up PR to ensure that we don't override cases where a user specifically set network interface.
|
@notnoop thanks a lot! |
|
This will be in 0.11.0 - it's in beta now and should be out in final soon. |
notnoop
pushed a commit
that referenced
this pull request
Apr 9, 2020
fingerprint: handle incomplete AWS imitation APIs
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression where we accidentally started treating non-AWS
environments as AWS environments, resulting in bad networking settings.
Two factors some at play:
First, in [1], we accidentally switched the ultimate AWS test from
checking
ami-idtoinstance-id. This means that nomad startedtreating more environments as AWS; e.g. Hetzner implements
instance-idbut not
ami-id.Second, some of these environments return empty values instead of
errors! Hetzner returns empty 200 response for
local-ipv4, resultinginto bad networking configuration.
This change fix the situation by restoring the check to
ami-idandensuring that we only set network configuration when the ip address is
not-empty. Also, be more defensive around response whitespace input.
Build https://circleci.com/gh/hashicorp/nomad/51933 shows the behavior (or failures) in these environments.
[1] #6779
Fixes #7232