UI error when no volumes are configured

[greut]

Nomad version

Nomad v0.11.0-beta1 (a7a7d12)

Operating system and Environment details

CentOS Linux release 7.7.1908 (Core)
Linux node-0 3.10.0-1062.18.1.el7.x86_64

Issue

nomad-ui-d8efc90d778a6bdb7947cabb4d2632d6.js:formatted:4003 Uncaught TypeError: Cannot read property 'sortBy' of null
    at r.<anonymous> (nomad-ui-d8efc90d778a6bdb7947cabb4d2632d6.js:formatted:4003)
    at r.i.get (vendor-bf3664ceb927a898f533450b8c468b46.js:2598)
    at Qe (vendor-bf3664ceb927a898f533450b8c468b46.js:2555)
    at t.n.compute (vendor-bf3664ceb927a898f533450b8c468b46.js:1813)
    at t.value (vendor-bf3664ceb927a898f533450b8c468b46.js:1803)
    at t.n.compute (vendor-bf3664ceb927a898f533450b8c468b46.js:1817)
    at t.value (vendor-bf3664ceb927a898f533450b8c468b46.js:1803)
    at t.value (vendor-bf3664ceb927a898f533450b8c468b46.js:4322)
    at e.t.initialize (vendor-bf3664ceb927a898f533450b8c468b46.js:4256)
    at e.t.peek (vendor-bf3664ceb927a898f533450b8c468b46.js:4251)

from the pretty printed JS, hostVolumes is null hence cannot be sorted by anything

        sortedHostVolumes: Ember.computed("[email protected]", function() {
            return this.model.hostVolumes.sortBy("name")
        }),

Reproduction steps

1. Upgrading from Nomad 0.10.4 without doing any other changes.
2. Visit /ui/clients/<a client>
3. Using Chromium (in my case, but it should apply to other browsers as well)

[tgross]

Hi @greut! Thanks for opening this. We'll look into it!

[tgross]

I was able to replicate this with a fresh 0.11.0-beta, just running nomad agent -dev. I wasn't able to replicate on the current master, however... I'm not sure I see which commit might have fixed that though. @DingoEatingFuzz might have a better answer.

[DingoEatingFuzz]

Classic nil value instead of empty object in the API response. Thank you for the report, @greut! PR open now.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.