api: alloc exec recovers from bad client connection #7274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If alloc exec fails to connect to the nomad client associated with the alloc, fail over to using a server. The code attempted to special case `net.Error` for failover to rule out other permanent non-networking errors, by reusing a pattern in the logging handling. But this pattern does not apply here. `net/http.Http` wraps all errors as `*url.Error` that is net.Error. The websocket doesn't, and instead returns the raw error. If the raw error isn't a `net.Error`, like in the case of TLS handshake errors, the api package would fail immediately rather than failover.
drewbailey
approved these changes
Mar 5, 2020
notnoop
pushed a commit
that referenced
this pull request
Apr 9, 2020
api: alloc exec recovers from bad client connection
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If alloc exec fails to connect to the nomad client associated with the
alloc, fail over to using a server.
The code attempted to special case
net.Errorfor failover to rule outother permanent non-networking errors, by reusing a pattern in the
logging handling.
But this pattern does not apply here.
net/http.Httpwraps all errorsas
*url.Errorthat is net.Error. The websocket doesn't, and insteadreturns the raw error. If the raw error isn't a
net.Error, like inthe case of TLS handshake errors, the api package would fail immediately
rather than failover.
Fixes #7233 .