Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging for CSI volumes endpoint #7118

Closed
tgross opened this issue Feb 11, 2020 · 4 comments · Fixed by #12186
Closed

Paging for CSI volumes endpoint #7118

tgross opened this issue Feb 11, 2020 · 4 comments · Fixed by #12186

Comments

@tgross
Copy link
Member

tgross commented Feb 11, 2020

CSI Volumes may be a very large collection of objects, so implement paging for the endpoint. The design should probably be based on request session specific tokens, so that the server can maintain state and avoid omitting volumes.

This needs an RFC (no precedent in nomad) and is not a blocker for the MVP.

@tgross tgross added this to the unscheduled milestone Feb 11, 2020
@tgross tgross added the theme/api HTTP API and SDK issues label Feb 11, 2020
@stale
Copy link

stale bot commented May 12, 2020

Hey there

Since this issue hasn't had any activity in a while - we're going to automatically close it in 30 days. If you're still seeing this issue with the latest version of Nomad, please respond here and we'll keep this open and take another look at this.

Thanks!

@tgross tgross removed this from the unscheduled milestone Feb 12, 2021
@tgross
Copy link
Member Author

tgross commented Apr 1, 2021

The CSI volume creation (#10165) and volume snapshot (#10245) workflows were forced to implement paging for the ListVolumes and ListSnapshots Controller RPCs. These were implemented with a NextToken and PerPage field in QueryOptions See api/api.go#L68-L74.

@tgross
Copy link
Member Author

tgross commented Feb 16, 2022

cc'ing @lgfa29 that he'll probably want to pick up this issue when implementing the pagination/filtering work he's doing elsewhere in the API.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant