Some fixes to connection pooling #7045
Conversation
Pick up some fixes from Consul: * If a stream returns an EOF error, clear session from cache/pool and start a new one. * Close the codec when closing StreamClient
| // new session next time | ||
| // See https://github.com/hashicorp/consul/blob/v1.6.3/agent/pool/pool.go#L471-L477 | ||
| if lib.IsErrEOF(err) { | ||
| p.clearConn(conn) |
There was a problem hiding this comment.
In getClient above on L406 we call release and clear in the opposite order. Looking at the code I don't think it matters and calling releaseConn doesn't even seem necessary if we're calling clearConn.
It might be nice to make the 2 clear+releaseConn cases the same, but it's not a blocker. I don't see any reason why either would be unsafe.
There was a problem hiding this comment.
Done - also your proposed order matches Consul's code too. Thanks for catching this.
This to be consistent with other connection clean up handler as well as consul's https://github.com/hashicorp/consul/blob/v1.6.3/agent/pool/pool.go#L468-L479 .
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Pick up some fixes from Consul: