Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull logic out of nomad/Job.Register into admission controllers #7020

Open
shoenig opened this issue Jan 30, 2020 · 2 comments
Open

Pull logic out of nomad/Job.Register into admission controllers #7020

shoenig opened this issue Jan 30, 2020 · 2 comments

Comments

@shoenig
Copy link
Member

shoenig commented Jan 30, 2020

The Job.Register function makes use of fancy new new admission controller tooling for validating only a couple of recent things. Let's extract more blocks of logic out of this function into their own controllers, e.g.

  • Volume Permissions
  • Enforce Modify Index
  • Valid Update Transitions
  • Vault Policy Permissions
  • Consul Connect Task Permissions
  • Sentinel Policy Enforcement

This will help make these critical bits of functionality more easily individually testable.

@stale
Copy link

stale bot commented Apr 29, 2020

Hey there

Since this issue hasn't had any activity in a while - we're going to automatically close it in 30 days. If you're still seeing this issue with the latest version of Nomad, please respond here and we'll keep this open and take another look at this.

Thanks!

@stale
Copy link

stale bot commented May 30, 2020

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants