Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage Cluster ID to help prevent joining discrete clusters #6736

Open
shoenig opened this issue Nov 19, 2019 · 3 comments
Open

Leverage Cluster ID to help prevent joining discrete clusters #6736

shoenig opened this issue Nov 19, 2019 · 3 comments

Comments

@shoenig
Copy link
Member

shoenig commented Nov 19, 2019

Now that we have a uniquely identifying Cluster ID (gh-6702), we could use it to prevent the joining of members participatory of another cluster. When a member is [re]joined, it should either have no existing Cluster ID, or a matching Cluster ID to the cluster it is being joined with. A non-matching Cluster ID is an indication that the member was participating in another cluster, and will have a non-sensical raft log & state store, likely causing some problems.

@adhaamehab
Copy link

Hi, Can I work on this? How should I start?

@shoenig
Copy link
Member Author

shoenig commented Mar 31, 2020

Hey @adhaamehab , of course contributions are welcome!

This particular feature is definitely going to require some spelunking through Nomad's source as it ties together elements of the CLI, API, Gossip, Raft, and leadership. It also needs to be well tested at each level to avoid breaking any existing functionality. To get started though, there's no better place than with the join CLI command, which is kind of the entry point of the request flow.

@adhaamehab
Copy link

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants