Always destroy exec container on cleanup #6722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
approved these changes
Nov 19, 2019
| @@ -251,6 +254,104 @@ func TestExecDriver_StartWaitRecover(t *testing.T) { | |||
| require.NoError(harness.DestroyTask(task.ID, true)) | |||
| } | |||
|
|
|||
| func TestExecDriver_DestroyKillsAll(t *testing.T) { | |||
There was a problem hiding this comment.
I'm a sucker for succinct descriptions on tests, but not a blocker.
Suggested change
| func TestExecDriver_DestroyKillsAll(t *testing.T) { | |
| // TestExecDriver_DestroyKillsAll asserts that when TaskDestroy is called all | |
| // task processes are cleaned up. | |
| func TestExecDriver_DestroyKillsAll(t *testing.T) { |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where executor based drivers may orphan processes. If exec task spawns off processes in background, doesn't propagate signals to them, and doesn't kill them on its own completion, the background processes get orphaned and remain running after Nomad task completes.
This fixes the issue by ensuring that containers get shutdown and destroyed even if exec init process terminated.