Check for changes to affinity, constraints and spread during update #6703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❓ If the same affinity is moved from the Job stanza into a TG stanza, this would result in a new alloc. Do we want to check for the calculated difference between all 3 possible levels of constraints/affinities? |
preetapan
reviewed
Nov 18, 2019
preetapan
suggested changes
Nov 18, 2019
drewbailey
force-pushed
the
b-affinity-constraint-inplace-update
branch
from
3ab5ba5 to
557f398
Compare
drewbailey
changed the title
preetapan
reviewed
Nov 18, 2019
preetapan
approved these changes
Nov 19, 2019
Adds checks for affinity and constraint changes when determining if we should update inplace. refactor to check all levels at once check for spread changes when checking inplace update
Fixes documentation inaccuracy for spread stanza placement. Spreads can only exist on the top level job struct or within a group. comment about nil assumption
drewbailey
force-pushed
the
b-affinity-constraint-inplace-update
branch
from
557f398 to
4196b27
Compare
Closed
drewbailey
added a commit
that referenced
this pull request
Feb 10, 2020
This PR reverts changes introduced in #6703 that made changes to affinities and spreads cause destructive updates. #6988 outlines good reason to rethink this until we have scheduler functionality in place that treats and update to spread/affinity similar to how count changes are handled (rebalancing the difference instead of rescheduling all allocs).
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds checks for affinity and constraint changes when determining if we
should update inplace.
fixes #6334