Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return a 404 if not found instead of redirect to ui #6658

Merged
merged 3 commits into from
Nov 11, 2019
Merged

return a 404 if not found instead of redirect to ui #6658

merged 3 commits into from
Nov 11, 2019

Conversation

drewbailey
Copy link
Contributor

@drewbailey drewbailey commented Nov 8, 2019 •
edited
Loading

If the request path is not equal to / 404 instead of redirecting to /ui.

fixes #6656

DingoEatingFuzz
DingoEatingFuzz requested changes Nov 8, 2019
View reviewed changes
command/agent/http.go Outdated Show resolved Hide resolved
@drewbailey drewbailey changed the title returns a 404 if not found instead of redirect to ui return a 404 if not found instead of redirect to ui Nov 8, 2019
@drewbailey drewbailey requested a review from schmichael November 8, 2019 21:02
notnoop
notnoop approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this - thank you so much for following through - it has been irking me for far too long :( .

very minor stylistic nit picking - merge away as you wish.

command/agent/http.go Outdated Show resolved Hide resolved
command/agent/http.go Outdated Show resolved Hide resolved
@drewbailey drewbailey merged commit 2f0c588 into master Nov 11, 2019
@drewbailey drewbailey deleted the b-404-redirect branch November 11, 2019 13:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DingoEatingFuzz DingoEatingFuzz DingoEatingFuzz requested changes

@notnoop notnoop notnoop approved these changes

@schmichael schmichael Awaiting requested review from schmichael

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 instead of 307 redirecting to /ui/
3 participants
@drewbailey @notnoop @DingoEatingFuzz