decompress response body from websocket error #6650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
reviewed
Nov 7, 2019
drewbailey
changed the title
notnoop
approved these changes
Nov 7, 2019
| // ensure the error is what we expect | ||
| _, err := a.Exec(context.Background(), alloc, "bar", false, []string{"command"}, os.Stdin, os.Stdout, os.Stderr, sizeCh, nil) | ||
| require.Contains(t, err.Error(), "Unexpected response code: 301") | ||
| require.Contains(t, err.Error(), "Moved Permanently") |
There was a problem hiding this comment.
Not your change but I find it very sad that we return redirect to /ui if an /v1/ endpoint isn't found.
There was a problem hiding this comment.
That is so strange. Filed an issue: #6656
If a websocket connection errors we currently return the error with a copy of the response body. The response body from the websocket can often times be completely illegible so remove it from the error string. make alloc id empty for more reliable failure un-gzip if content encoding header present
drewbailey
force-pushed
the
b-better-ws-error
branch
from
369a0ef to
7864705
Compare
drewbailey
force-pushed
the
b-better-ws-error
branch
from
7864705 to
69751a7
Compare
drewbailey
changed the title
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a websocket connection errors we currently return the error with a
copy of the response body. The response body from the websocket can
often times be gzipped, so check if the content-encoding was gzipped
and decompress.
Example error responses that were getting appended:
which was the result of the following response body
fixes #6545