Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate nomad variables in task environment variables #653

Merged
merged 4 commits into from
Jan 12, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Jan 6, 2016

This PR adds:

  • Interpolation of nomad variables (e.g. $nomad.id) in environment variables
  • Combines the argument parser and TaskEnvironment
  • Introduces a ExecutorContext (similar to DriverContext)

Fixes #538, fixes #448 and fixes #326

@diptanu
Copy link
Contributor

diptanu commented Jan 10, 2016

@dadgar Let's add some docs too?

dadgar added a commit that referenced this pull request Jan 12, 2016
Interpolate nomad variables in task environment variables
@dadgar dadgar merged commit 9b00c9e into master Jan 12, 2016
@dadgar dadgar deleted the f-interpret-vars branch January 12, 2016 01:56
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants