Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an enabled boolean parameter for all plugins #6477

Open
preetapan opened this issue Oct 11, 2019 · 3 comments
Open

Add an enabled boolean parameter for all plugins #6477

preetapan opened this issue Oct 11, 2019 · 3 comments

Comments

@preetapan
Copy link
Contributor

preetapan commented Oct 11, 2019

Problem

Right now there are a couple different ways to disable plugins:

  • Drivers may be in the denylist

  • External plugins may be deleted

However there's no way to disable builtin device plugins, and having 2 ways of disabling driver plugins is confusing.

Proposal

Plugin stanzas should universally support an enabled boolean that defaults to true. This provides a consistent control mechanism that works for builtin and external plugins.

Once there is a universal mechanism for disabling plugins, a deprecation warning should be emitted when the original task driver denylist is specified. An issue should be filed against 0.X+2 to remove the denylist entirely. (So if this is released in 0.11.0, the denylist should be removed in 0.13.0).

@preetapan preetapan added this to the near-term milestone Oct 11, 2019
@tgross tgross modified the milestones: near-term, unscheduled Jan 9, 2020
@shantanugadgil
Copy link
Contributor

I need this! I have an old NVIDIA card with older drivers, which doesn't work with Nomad.
ref: #8303

@tgross tgross removed this from the unscheduled milestone Feb 12, 2021
@dpogorzelski
Copy link

Hello, is there any update on this feature? :)

@tgross
Copy link
Member

tgross commented Mar 19, 2021

Hi @dpogorzelski. Nope, this hasn't managed to make its way onto the roadmap.

We already have support for it in two drivers that are particularly troublesome for some users: the Nvidia device driver supports the enabled flag and raw_exec supports it as well. But it's not enforced as universal across the generic plugin configuration yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants