remove consul service stanza from job init --short example jobspec
#6179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
reviewed
Aug 21, 2019
command/assets/example-short.nomad
Outdated
| @@ -16,24 +16,6 @@ job "example" { | |||
| resources { | |||
| cpu = 500 | |||
| memory = 256 | |||
|
|
|||
| network { | |||
There was a problem hiding this comment.
I think you are going to still need the dynamic port.
There was a problem hiding this comment.
the network stanza is good to keep, as db port is used above; but let's remove service stanza here.
jazzyfresh
force-pushed
the
f-job-init-shorter
branch
from
2fbaec9 to
0b92edb
Compare
notnoop
approved these changes
Aug 27, 2019
jazzyfresh
force-pushed
the
f-job-init-shorter
branch
from
0b92edb to
dd505fd
Compare
jazzyfresh
changed the title
job init --short example jobspecjob init --short example jobspec
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems standard to remove the networking component from the example jobspec that is produced by
job init --short. This is an attempt to clean it up for the bare minimum for development.Todo