Sort output of agent-info #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| d, _ := data.(map[string]interface{}) | ||
| for k, v := range d { | ||
| c.Ui.Output(fmt.Sprintf(" %s = %v", k, v)) | ||
| for _, key := range statsDataKeys { |
There was a problem hiding this comment.
key is shadowed in a few places. It's obviously using the inner value but the shadowing is a bit awkward. Can we change these variables names so they don't shadow?
There was a problem hiding this comment.
Feel free to just commit to master making the desired name changes @cbednarski
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting output of agent-info makes it much more user-friendly.