Handle non 200 codes while getting env metadata #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,6 +116,9 @@ func (f *EnvAWSFingerprint) Fingerprint(cfg *config.Config, node *structs.Node) | |||
| } | |||
| for _, k := range keys { | |||
| res, err := client.Get(metadataURL + k) | |||
| if res.StatusCode != 200 { | |||
There was a problem hiding this comment.
I would probably log something here with WARN, just so people can see why some of AWS metadata is not showing up upon nomad node-status
There was a problem hiding this comment.
@achanda Another small nitpick, can we do res.StatusCode != http. StatusOK instead of 200?
| @@ -94,7 +94,8 @@ func (f *EnvGCEFingerprint) Get(attribute string, recursive bool) (string, error | |||
| } | |||
|
|
|||
| res, err := f.client.Do(req) | |||
| if err != nil { | |||
| if err != nil || res.StatusCode !=200 { | |||
| f.logger.Printf("[WARN]: fingerprint.env_gce: Could not read value for attribute %s", k) | |||
There was a problem hiding this comment.
It looks like k is not defined here.
dadgar
added a commit
that referenced
this pull request
Dec 22, 2015
Handle non 200 codes while getting env metadata
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% sure what the behavior should be here. Please comment.
cc @c4milo