Throwing an error if ports are not named instead of crashing while parsing a job spec #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptanu
changed the title
|
Much better than a panic. Thank you! 👍 |
| @@ -623,6 +623,9 @@ func parsePorts(networkObj *ast.ObjectList, nw *structs.NetworkResource) error { | |||
| portsObjList := networkObj.Filter("port") | |||
| knownPortLabels := make(map[string]bool) | |||
| for _, port := range portsObjList.Items { | |||
| if len(port.Keys) == 0 { | |||
| return fmt.Errorf("Nomad expects ports to be named") | |||
There was a problem hiding this comment.
I would make the message. "ports must be named". They know its from Nomad :)
diptanu
added a commit
that referenced
this pull request
Dec 18, 2015
Throwing an error if ports are not named instead of crashing while parsing a job spec
|
hotfixed error message on master. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nomad currently panics if ports are not named. This change makes Nomad throw an error instead which might be more comprehendable for an user.
Fixes #603